Skip to contentSkip to conversation

abseil-cpp: readd use of -std=c++14

PATCH In review [email protected] 2 participants 5 messages Jan 9, 2024 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 abseil-cpp: readd use of -std=c++14

From: Thomas Roos <[email protected]>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well. Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb +1 -0
index ee62d4b59..1a713e1c5 100644
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake
 
 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "
Signature · 14 lines
2.34.1




Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg
Sitz der Gesellschaft: L-1855 Luxemburg
eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland
Marcel-Breuer-Str. 12, D-80807 Muenchen
Sitz der Zweigniederlassung: Muenchen
eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094
#1 lore raw

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: [email protected]
Cc: Thomas Roos <[email protected]>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <[email protected]>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well. Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb +1 -0
index ee62d4b59..1a713e1c5 100644
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake
 
 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "

--
2.34.1

Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: [email protected]; [email protected]
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: [email protected]
Cc: Thomas Roos <[email protected]>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <[email protected]>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well. Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb +1 -0
index ee62d4b59..1a713e1c5 100644
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake
 
 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "

--
2.34.1

Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094

A message that is not in the archive (sent off-list or not yet received): [email protected]

#5 lore raw

Sorry, typo, on the master branch

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:24 PM
To: Petr Chernikov <[email protected]>; [email protected]; [email protected]
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: [email protected]; [email protected]
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: [email protected]
Cc: Thomas Roos <[email protected]>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <[email protected]>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well. Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb +1 -0
index ee62d4b59..1a713e1c5 100644
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake
 
 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "

--
2.34.1

Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094

#6 lore raw

Hi,
good news - I could solve this problem by patching out the hardcoded -std=c++14 in our software (meta-aws). Sorry for the noise.
Please ignore this patch.

Cheers,
Thomas

________________________________
Von: Petr Chernikov <[email protected]>
Gesendet: Dienstag, 9. Januar 2024 14:26:20
An: Petr Chernikov; Roos, Thomas; [email protected]
Betreff: RE: [EXTERNAL] [oe] [PATCH] abseil-cpp: readd use of -std=c++14

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.

Sorry, typo, on the master branch

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:24 PM
To: Petr Chernikov <[email protected]>; [email protected]; [email protected]
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Also I'm able to compile protobuf and protobuf-native without any changes on nanbield branch

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Petr Chernikov
Sent: Tuesday, January 9, 2024 4:15 PM
To: [email protected]; [email protected]
Subject: Re: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

Perhaps, better solution is to use c++17 for both packages:
https://github.com/protocolbuffers/protobuf/issues/10768#issuecomment-1773175439

Regards
Pete

-----Original Message-----
From: [email protected] <[email protected]> On Behalf Of Thomas Roos via lists.openembedded.org
Sent: Tuesday, January 9, 2024 3:44 PM
To: [email protected]
Cc: Thomas Roos <[email protected]>
Subject: [oe] [PATCH] abseil-cpp: readd use of -std=c++14

From: Thomas Roos <[email protected]>

Protobuf is compiled with -std=c++14, so abseil-cpp must be as well. Details can be found here: https://github.com/protocolbuffers/protobuf/issues/10768

---
 meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta-oe/recipes-devtools/abseil-cpp/abseil-cpp_git.bb +1 -0
index ee62d4b59..1a713e1c5 100644
@@ -26,6 +26,7 @@ ASNEEDED:class-nativesdk = ""
 inherit cmake
 
 EXTRA_OECMAKE = "-DBUILD_SHARED_LIBS=ON \
+                 -DCMAKE_CXX_STANDARD=14 \
                  -DBUILD_TESTING=OFF    \
                  -DABSL_ENABLE_INSTALL=ON \
                 "

--
2.34.1

Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg Sitz der Gesellschaft: L-1855 Luxemburg eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland Marcel-Breuer-Str. 12, D-80807 Muenchen Sitz der Zweigniederlassung: Muenchen eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094

Amazon Web Services EMEA SARL
38 avenue John F. Kennedy, L-1855 Luxembourg
Sitz der Gesellschaft: L-1855 Luxemburg
eingetragen im Luxemburgischen Handelsregister unter R.C.S. B186284

Amazon Web Services EMEA SARL, Niederlassung Deutschland
Marcel-Breuer-Str. 12, D-80807 Muenchen
Sitz der Zweigniederlassung: Muenchen
eingetragen im Handelsregister des Amtsgerichts Muenchen unter HRB 242240, USt-ID DE317013094